feat: bring resizable image back to editor#4226
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
feat: bring resizable image back to editor#4226devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Add ResizableNodeView from @tiptap/core for image resize support - Add width/height attributes to AttachmentImage extension - Add custom addNodeView() with resize handles and callbacks - Add extractAttachmentIdFromSrc helper for parseMarkdown - Configure resize directions (all 8 directions) - Add CSS styles for resize handles Closes #3327 Co-Authored-By: John <john@hyprnote.com>
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings back resizable image support in the tiptap editor, as described in #3327. This uses the
ResizableNodeViewAPI from@tiptap/corev3.x to add drag-to-resize handles on images.Key changes:
packages/tiptap/src/shared/extensions/index.ts: Addswidth/heightattributes toAttachmentImage, implements a customaddNodeView()usingResizableNodeViewwith resize/commit callbacks, addsextractAttachmentIdFromSrc()helper forparseMarkdown, and enables resize with all 8 directions.packages/tiptap/src/styles/base.css: Addsposition: relativeon.node-image, a globalimg { display: block }rule inside.tiptap, and CSS for all resize handle variants (corners + edges) with appropriate cursors.Review & Testing Checklist for Human
onCommitwith multiple images:editor.commands.updateAttributes("image", ...)targets the currently selected node — confirm that resizing one image doesn't affect dimensions of other images in the same document.addNodeView()returningnull: Whenresizeis disabled or not configured (e.g. viaoptions.imageExtension), the method returnsnull. Verify tiptap handles this gracefully and falls back to the default image rendering.img { display: block }rule: This applies to allimgtags inside.tiptap— confirm it doesn't break non-image-node images or inline image use cases.extractAttachmentIdFromSrcregex: Verify it correctly extracts UUIDs from your actual attachment URLs and returnsnullfor non-attachment URLs (e.g. external image links).Notes