Skip to content

feat: StarlingMonkey upgrade#1394

Closed
TartanLlama wants to merge 41 commits into
v4.0from
sy/starling-monkey-upgrade
Closed

feat: StarlingMonkey upgrade#1394
TartanLlama wants to merge 41 commits into
v4.0from
sy/starling-monkey-upgrade

Conversation

@TartanLlama

@TartanLlama TartanLlama commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Bumps wasi-sdk to v30 from v20
  • Bumps rustc to 1.88 from 1.81
  • Moves from the old NPM wizer package to pulling down wasmtime and using the version of wizer bundled with wasmtime
  • Uses the new policy-based way of defining finalizable builtins
  • Stubs out parts of AbortSignal and AbortController that are usid in other places in StarlingMonkey
  • Fixes compiler diagnostics that are triggered based on the wasi-sdk bump
  • Fixes misplaced namespace in fastly.h
  • Removes the now-unnecessary copy of rust-toolchain.toml
  • Updates wpt expectations

Docs still todo

@cupofjoakim cupofjoakim mentioned this pull request Apr 8, 2026
Open
@TartanLlama TartanLlama marked this pull request as ready for review April 10, 2026 10:43
@TartanLlama TartanLlama marked this pull request as draft April 10, 2026 10:46
@TartanLlama

TartanLlama commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

@zkat can you suggest what docs changes would be required for the SPKI and PKCS8 support?

@TartanLlama TartanLlama marked this pull request as ready for review April 13, 2026 11:28
TartanLlama and others added 23 commits April 22, 2026 08:51
@TartanLlama
fix: Use length rather than NUL-terminator when copying HostStrings (…
8aa3f4c 
…#1429)
@TartanLlama
fix: Reset StarlingMonkey engine between requests (#1426)
238cf70
@TartanLlama
fix: Check pending exceptions between requests in reusable sandbox mo…
64a6b21 
…de (#1425)
@harmony7 @TartanLlama
docs: Clarify doc of Headers.prototype.get by aligning it with MDN (#…
efe0331 
…1430)

Co-authored-by: Sy Brand <tartanllama@gmail.com>
@TartanLlama
chore: Bump undici in tests (#1421)
cbf0d5e
@TartanLlama
chore: Bump Fastly CLI version (#1419)
99a9f04
@TartanLlama @ulyssa
testing: Add integration test for verifying when FetchEvent gets mark…
3ac1f12 
…ed done (#1435)

Co-authored-by: Ulyssa <git@ulyssa.dev>
@TartanLlama
fix: Memory issues exposed by high GC zeal (#1442)
f406308
@dependabot @zkat
chore(deps): bump the npm group across 1 directory with 5 updates (#1432
20b0a0c 
)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@TartanLlama
fix: Potential buffer size issues in shielding (#1443)
4bf9d72
@zkat
chore: make CI more reliable (#1450)
fb0480c
@TartanLlama @zkat
fix: HttpBody::read_all for large bodies (#1444)
99f45b5 
Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
@TartanLlama @zkat
fix: mislabeled Response::Slots::URL slot (#1445)
6d4d268 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@TartanLlama @zkat
fix: SSL string cipher intersection (#1446)
13ef2d5 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@zkat
make test teardown more robust (#1452)
1c6d13d
@TartanLlama @zkat
fix: Numeric overflow issue in Core Cache API (#1448)
360c9bf 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@TartanLlama @zkat
fix: Memory leak in normalize_http_method (#1449)
669b58a 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@github-actions @zkat
chore(main): release 3.41.2 (#1431)
4b3a1d8 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: zkat <zkat@users.noreply.github.com>
Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
@TartanLlama @zkat
fix: Protect against GC from validate_bytes (#1447)
be0867b 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@TartanLlama @zkat
feat: Bail out of reusable sandbox if request fails (#1453)
b6f41b0 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@zkat
chore: fix up docusaurus tests (#1470)
4dd125f
@zkat @mcinerney
fix: Correct GC guard type in KVStore::put to prevent wasm unreachabl…
15f850d 
…e crashes and fix some CI issues (#1475)

Co-authored-by: Peter McInerney <peter.mcinerney@fastly.com>
@TartanLlama
fix: Memory leak on failed inspect hostcall (#1455)
9b77977
TartanLlama and others added 6 commits May 11, 2026 10:45
@TartanLlama @zkat
fix: Shrinking realloc in KVStorePendingLookup (#1467)
5a72d13 
Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
@TartanLlama @zkat
fix: Cache body range check (#1463)
f38ce55 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
@TartanLlama @zkat
fix: Throw error on negative ttl and swr (#1465)
7d29650 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@TartanLlama @zkat
fix: Find invalid characters after nul bytes in KV store keys (#1464)
5f0f0f2 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
@TartanLlama @zkat
fix: Be more defensive in ip_octets_to_js_string (#1468)
60bbec1 
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@github-actions @zkat
chore(main): release 3.42.0 (#1454)
ea70fcd 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
@zkat

zkat commented May 11, 2026

Copy link
Copy Markdown
Member

@TartanLlama We should probably build a table in our docs somewhere that shows supported operations/algorithms for subtlecrypto /cc @harmony7

zkat
zkat reviewed May 12, 2026
View reviewed changes
Comment thread runtime/fastly/host-api/host_api.cpp
Comment thread tests/wpt-harness/expectations/streams/readable-streams/templated.any.js.json
@zkat zkat force-pushed the sy/starling-monkey-upgrade branch 2 times, most recently from eac4ab3 to b435497 Compare May 14, 2026 17:24
@zkat zkat force-pushed the sy/starling-monkey-upgrade branch 2 times, most recently from 9a33d40 to 9080baa Compare May 14, 2026 18:20
@TartanLlama TartanLlama force-pushed the sy/starling-monkey-upgrade branch from 9080baa to 9a33d40 Compare May 18, 2026 16:38
TartanLlama and others added 2 commits May 18, 2026 13:10
@TartanLlama @zkat
fix: Null body for non-downstream requests with no stream created for…
511c667 
… them (#1479)
@github-actions @zkat
chore(main): release 3.42.1 (#1478)
80fb56a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
@zkat zkat force-pushed the sy/starling-monkey-upgrade branch from 9a33d40 to 6fd622d Compare May 19, 2026 17:26
@TartanLlama @cceckman-at-fastly
@harmony7 @ulyssa @zkat
feat: stale-if-error support (#1307)
3e06237 
Co-authored-by: Charles Eckman <charles.eckman@fastly.com>
Co-authored-by: Katsuyuki Omuro <komuro@fastly.com>
Co-authored-by: Ulyssa <git@ulyssa.dev>
Co-authored-by: Kat Marchán <kzm@zkat.tech>
@zkat zkat force-pushed the sy/starling-monkey-upgrade branch 4 times, most recently from 441e260 to 78ac6f9 Compare June 11, 2026 17:09
@zkat zkat mentioned this pull request Jun 11, 2026
Open
@zkat zkat force-pushed the sy/starling-monkey-upgrade branch from 78ac6f9 to 442ded7 Compare June 11, 2026 17:14
@zkat

zkat commented Jun 11, 2026

Copy link
Copy Markdown
Member

Superseded by #1490 because we're landing this on main instead

@zkat zkat closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zkat zkat zkat approved these changes

Assignees

@zkat zkat

@TartanLlama TartanLlama

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TartanLlama @zkat @mcinerney @harmony7