Add support for Healthchecking Dynamic Backends#635
Open
camilee03 wants to merge 3 commits into
Open
Conversation
Member
|
Does this prevent sending http requests to unhealthy backends too? |
Member
Author
|
@dgryski No, it doesn't. This is focused on adding healthchecks as an option to dynamic backends on creation re the work in ExecuteD along similar lines, not on the other side of when a user tries to query a created backend and healthcheck it. Unless I've misinterpreted the code for Viceroy, and it's different from ExecuteD, I believe that functionality shouldn't ~need to be changed because once the dynamic backend is built, it is processed the same way as a static backend (lmk if that assumption is incorrect)? |
Member
|
When backend health was added to viceroy, the status was not checked during an http send. So, no change then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meant to support the changes made in this PR in the Rust SDK to support healthchecking hostcalls for dynamic backends
There is additional healthchecking-related terminology like here, which sets backend health to
BackendHealth::Unknown(which the static backend sets as a config). This should be fine to leave as is.