Refactor profiling configuration to use unified ProfilingConfig enum#598
Open
posborne wants to merge 1 commit into
Open
Refactor profiling configuration to use unified ProfilingConfig enum#598posborne wants to merge 1 commit into
posborne wants to merge 1 commit into
Conversation
Replace the confusing dual profiling configuration system (ProfilingStrategy + GuestProfileConfig) with a single, unified ProfilingConfig enum that cleanly distinguishes between native profiling (PerfMap/JitDump/VTune) and guest profiling (Firefox Profiler format).
posborne
force-pushed
the
profiling-config-unification
branch
from
b5252d6 to
0a9ede6
Compare
dgohman-fastly
approved these changes
Jun 12, 2026
dgohman-fastly
left a comment
dgohman-fastly
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay here; this looks good to me, though it'll need a rebase now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the confusing dual profiling configuration system (ProfilingStrategy + GuestProfileConfig) with a single, unified ProfilingConfig enum that cleanly distinguishes between native profiling (PerfMap/JitDump/VTune) and guest profiling (Firefox Profiler format).