Added Command Description and also command dump#4
Open
wx4cb wants to merge 1 commit intofakufaku:masterfrom
Open
Added Command Description and also command dump#4wx4cb wants to merge 1 commit intofakufaku:masterfrom
wx4cb wants to merge 1 commit intofakufaku:masterfrom
Conversation
fakufaku
requested changes
May 23, 2018
Owner
fakufaku
left a comment
There was a problem hiding this comment.
Thanks for the pull request. I have two suggestions.
- Changing the code from using
Serialto a stream will break the existing code, so unless there are really important benefits, I would not do that. - Can we make the description optional by providing a NULL as description ? In which case no memory would be allocated.
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.