feat: Add extra-platforms feature for non-atomic targets#70
Open
ericschaal wants to merge 1 commit intofaern:mainfrom
Open
feat: Add extra-platforms feature for non-atomic targets#70ericschaal wants to merge 1 commit intofaern:mainfrom
extra-platforms feature for non-atomic targets#70ericschaal wants to merge 1 commit intofaern:mainfrom
Conversation
Owner
|
This sounds good to me! Sorry for the slow review. Would you be willing to rebase this to resolve the conflicts? Primarily the imports moved to a dedicated |
e88097d to
89895fb
Compare
89895fb to
8e51a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new Cargo feature,
extra-platforms, to add support for hardware targets that lack native atomic CAS operations.The library relies on
AtomicU8, which is not available on all platforms (e.g., certain embedded targets likeriscv32iorthumbv6m). This prevents the crate from being used in those environments.This change "poly-fills" the required atomic types by adding an optional dependency on the
portable-atomiccrate.I'm using a similar approach to the bytes crate.