Regenerate pt2_et trace with corrected stream_id, fix test#207
Closed
leloleo wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Regenerate pt2_et trace with corrected stream_id, fix test#207leloleo wants to merge 1 commit intofacebookresearch:mainfrom
leloleo wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
leloleo
requested review from
briancoutinho,
kingchc,
louisfeng,
shengbao-zheng and
sunghlin
as code owners
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75181044 |
shengfukevin
approved these changes
May 22, 2025
Contributor
shengfukevin
left a comment
shengfukevin
left a comment
There was a problem hiding this comment.
Thanks for this fix. LG2M!
leloleo
added a commit
to leloleo/param
that referenced
this pull request
May 22, 2025
…esearch#207) Summary: This diff regenerates the pt2_et.json.tar.gz trace file used in the test_et_replay.py test file. Reviewed By: shengfukevin Differential Revision: D75181044
…esearch#207) Summary: Pull Request resolved: facebookresearch#207 This diff regenerates the pt2_et.json.tar.gz trace file used in the test_et_replay.py test file. Reviewed By: shengfukevin Differential Revision: D75181044
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75181044 |
Contributor
|
This pull request has been merged in 2de6085. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This diff regenerates the pt2_et.json.tar.gz trace file used in the test_et_replay.py test file.
Reviewed By: shengfukevin
Differential Revision: D75181044