Skip to content

Improve TOC link visibility with updated styles#334

Closed
clicktodev wants to merge 1 commit intofacebookincubator:mainfrom
clicktodev:better-active-state-toc
Closed

Improve TOC link visibility with updated styles#334
clicktodev wants to merge 1 commit intofacebookincubator:mainfrom
clicktodev:better-active-state-toc

Conversation

@clicktodev
Copy link
Copy Markdown
Contributor

@clicktodev clicktodev commented Dec 20, 2025

Enhance the hover and active states of table of contents links for better visibility and user experience.

before

Screen.Recording.2025-12-20.at.6.38.46.PM.mp4

after: this feels like a much better and accessible default

Screen.Recording.2025-12-20.at.7.08.15.PM.mp4

related to facebook/react-native-website#4934

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 20, 2025

Deploy Preview for infima ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9783397
🔍 Latest deploy log https://app.netlify.com/projects/infima/deploys/6946e5213d433000081101d4
😎 Deploy Preview https://deploy-preview-334--infima.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Dec 22, 2025

Thanks for the suggestion but it's not really the design direction I'd like to take with the TOC.

None of the competing solution uses underline, and this kind of design looks more polished to me:

CleanShot 2025-12-22 at 14 18 13

This would also permit to highlight all the headlines that are currently visible on the page, and not just one like it's the case today

@slorber slorber closed this Dec 22, 2025
@clicktodev
Copy link
Copy Markdown
Contributor Author

the design you shared looks good. do you plan to implement this yourself or are you willing to accept a PR?

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Dec 24, 2025

The best would be for someone, or us, to implement it on a real website with swizzle. Then we can consider making it the new design, but maybe this ui change is too disruptive for a minor version ?

1 similar comment
@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Dec 24, 2025

The best would be for someone, or us, to implement it on a real website with swizzle. Then we can consider making it the new design, but maybe this ui change is too disruptive for a minor version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants