Add C API bindings for manifest and file size tuning options#14848
Open
dheerajd5 wants to merge 1 commit into
Open
Add C API bindings for manifest and file size tuning options#14848dheerajd5 wants to merge 1 commit into
dheerajd5 wants to merge 1 commit into
Conversation
ac97564 to
f201108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix issue : #14285
Expose
max_manifest_space_amp_pctandtarget_file_size_is_upper_boundto the C API.rocksdb_options_set_max_manifest_space_amp_pcttakes in introcksdb_options_get_max_manifest_space_amp_pctreturns introcksdb_options_set_target_file_size_is_upper_boundtakes in unsigned charrocksdb_options_get_target_file_size_is_upper_boundreturns unsigned charAllows C API users to have more finer grained control over manifest and SST file sizings.
Test Plan
c_test, under "options" , to validate getter and setters for the two fields.