Conversation
zurfyx
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7 and
potatowagon
as code owners
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bump the pinned package manager from pnpm@10.34.1 to pnpm@11.10.0 and adapt config to pnpm 11's breaking changes: - pnpm 11 no longer reads the "pnpm" field in package.json, so move overrides and peerDependencyRules into pnpm-workspace.yaml. - Remove .pnpmrc: pnpm 11 does not read it (and pnpm never did). Its node-linker=hoisted setting was therefore inert — the repo builds and the ESM (.mjs) tests pass on pnpm's default (isolated) linker — and its onnxruntime-node-install=skip setting is moot since onnxruntime-node is stubbed via an override. - Replace the deprecated "$yjs" override reference with a catalog entry and catalog: reference to silence the pnpm 11 deprecation warning. - Declare dependency build scripts as disabled (allowBuilds) to preserve the pre-migration behavior where no build scripts were approved. - Bump engines.pnpm to >=11.0.0 and update the maintainers' guide. pnpm-lock.yaml is unchanged (no dependency resolution drift). Verified against a clean --frozen-lockfile install: ci-check (tsc/flow/prettier/ lint), test-unit (4610 passed), and build all pass under pnpm 11.10.0.
Deploy note: enable Corepack on the Vercel projectsThe Vercel checks fail until Corepack is enabled, because Vercel defaults to pnpm 9.x (it infers the version from Relaxing Fix (one-time, per project): on the |
| "Safari >= 15", | ||
| "Edge >= 86" | ||
| ], | ||
| "pnpm": { |
There was a problem hiding this comment.
This refactoring also needs to happen for the examples in order for the integration tests to pass
2 participants
Summary
Upgrades the pinned package manager from
pnpm@10.34.1topnpm@11.10.0and adapts the repo config to pnpm 11's breaking changes.pnpm-lock.yamlis unchanged — no dependency resolution drift; this is a package-manager version bump plus config relocation.Changes
packageManager→pnpm@11.10.0,engines.pnpm→>=11.0.0.overridesandpeerDependencyRulesout ofpackage.jsonintopnpm-workspace.yaml— pnpm 11 no longer reads thepnpmfield inpackage.json..pnpmrc→pnpm-workspace.yaml— pnpm 11 no longer reads.pnpmrc.node-linker=hoisted(required for the ESM.mjstests) becomesnodeLinker: hoisted. Theonnxruntime-node-install=skipsetting is dropped as dead config (onnxruntime-nodeis already stubbed via an override).yjsoverride now uses a catalog (catalog:) instead of the deprecated$yjsreference syntax, silencing pnpm 11's deprecation warning. Same resolved version.allowBuildsdeclared (all disabled) to preserve the pre-migration behavior where no dependency build scripts were approved (matches pnpm 10, on which CI passed with prebuilt binaries).CI needs no changes —
pnpm/action-setup@v6derives the version from thepackageManagerfield.Test plan
All run locally under pnpm 11.10.0:
pnpm install --frozen-lockfile(lockfile consistent, stilllockfileVersion: 9.0)node_modulesconfirmed hoistedpnpm run ci-check— tsc, tsc-scripts, tsc-extension, tsc-website, flow, prettier, lint (no errors)pnpm run test-unit— 216 files, 4610 passed, 1 skippedpnpm run build