[lexical-playground] Bug Fix: Clear inline font-size when converting to heading#8800
Merged
Merged
Conversation
…to heading When converting text to a heading, inline font-size styles on text nodes took CSS precedence over the heading class font-size, making the heading format visually ineffective. Clear the font-size inline style after applying the heading block type so the heading CSS class controls the size. Closes facebook#5509
mayrang
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
$setBlocksType calls replace() which clones and replaces the editor selection, leaving the original selection variable stale. Using it with $patchStyleText caused a "no common ancestor" error when the selection spanned decorator nodes.
etrepum
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converting text with a custom font-size to a heading (H1/H2/H3) had no visible effect on the text size. The inline
font-sizestyle on the text nodes took CSS precedence over the heading class'sfont-size, so the heading always appeared at whatever size the user had set manually.After
$setBlocksTypeconverts the block,$patchStyleTextnow clears thefont-sizeinline style so the heading class controls the size. Other inline styles (bold, color, font-family) are preserved since they don't conflict with the heading's core visual identity.Closes #5509
Test plan