Generalize RN build triggers/guard for future trains + bump version to 260318099.0.0#2101
Closed
cipolleschi wants to merge 2 commits into
Closed
Generalize RN build triggers/guard for future trains + bump version to 260318099.0.0#2101cipolleschi wants to merge 2 commits into
cipolleschi wants to merge 2 commits into
Conversation
Make static_h the source of truth so branches cut for future release trains
(e.g. 26xxxx/27xxxx) inherit the correct behavior without manual edits:
- Triggers: use globs ('*-stable', '*-staging') for push and pull_request so
any future stable/staging branch runs the RN build automatically.
- Guard: force dry-run for static_h and any '*-staging' branch (even via
workflow_dispatch). '*-stable' branches are unaffected and can still release.
'250829098.0.0-stable' is now covered by the '*-stable' glob.
meta-cla
Bot
added
the
CLA Signed
Advance static_h to the next release train's version.
cipolleschi
changed the title
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D110871622. |
cortinico
approved these changes
Jul 7, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@cipolleschi merged this pull request in b56d339. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
static_hthe source of truth for the RN build's branch handling, so branches cut for future release trains (e.g.26xxxx.*,27xxxx.*) inherit the correct behavior automatically — no per-branch edits torn-build-hermes.yml. Also advances the package version to the next train.This is the generic form of what #2100 did for
260318099.0.0-staging.1. Triggers → globs
pushandpull_requestnow matchstatic_h,'*-stable', and'*-staging'instead of listing individual branches. Any future stable/staging branch runs the RN build (and is verified on its PRs) out of the box.250829098.0.0-stableis now covered by'*-stable'.2. Dry-run guard → generalized
set_release_typeforcesRELEASE_TYPE=dry-runforstatic_hand any branch whose name ends in-staging, regardless of event — includingworkflow_dispatch, which has no branch filter and could otherwise be used to cut a real release from a staging branch.3. Bump version
npm/hermes-compiler/package.jsonbumped from250829098.0.0to260318099.0.0(the next release train's version).Behavior
static_h*-staging(any)*-stable(any)workflow_dispatchwithreleaseNote: pushing to a
*-stablebranch is dry-run (falls through to theelse); an actual release still only happens via a manualworkflow_dispatchselectingreleaseon a stable branch — unchanged from today.Test Plan
static_h+*-stagingand leaves*-stablereleasable.[static_h, *-stable, *-staging]for bothpushandpull_request.package.jsonis valid and version is260318099.0.0.