Enable CI on 260318099.0.0-stable and bump version to 260318099.0.0#2098
Open
cipolleschi wants to merge 3 commits into
Open
Enable CI on 260318099.0.0-stable and bump version to 260318099.0.0#2098cipolleschi wants to merge 3 commits into
cipolleschi wants to merge 3 commits into
Conversation
The reusable build workflows (build-hermesc-windows/apple/linux, build-android, etc.) only run when the rn-build-hermes.yml orchestrator calls them. That orchestrator's push trigger allowlists specific branches, and this release branch was missing, so pushes to 260318099.0.0-stable never kicked off the Hermes builds. Add it to the allowlist.
meta-cla
Bot
added
the
CLA Signed
The push trigger alone means CI only runs after a change lands. Add the release branch to the pull_request base-branch filter so PRs targeting 260318099.0.0-stable are verified before merge.
cipolleschi
changed the title
Align the package version on the 260318099.0.0-stable release branch with the branch's release train (was still 250829098.0.0).
cipolleschi
changed the title
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D110871586. |
cortinico
approved these changes
Jul 7, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jul 7, 2026
…2098) Summary: Prepares the `260318099.0.0-stable` release branch for releasing: ### 1. Run CI on the branch (push + PRs) The build jobs (`build_hermesc_windows`, `build_hermesc_apple`, `build_hermesc_linux`, `build_android`, etc.) are reusable `on: workflow_call` workflows — they only run when the orchestrator `rn-build-hermes.yml` ("RN Build Static Hermes") invokes them, and its `push`/`pull_request` triggers use branch allowlists that were missing this release branch. Added `260318099.0.0-stable` to **both**: - **push** — builds run automatically once a change lands on the release branch. - **pull_request** — builds run on PRs targeting the release branch, so changes are verified *before* merge. ### 2. Bump package version `npm/hermes-compiler/package.json` was still `250829098.0.0` (the previous train). Bumped it to `260318099.0.0` to match this branch's release train. ## Verification Confirmed on this PR: the `RN Build Static Hermes` workflow is triggered by the `pull_request` event, and `set_release_type` + the `build_hermesc_*` / `build_android` jobs run. ## Note The allowlists must be updated by hand for every new stable branch. A follow-up could switch them to a glob (e.g. `- '*-stable'`) so future release branches are covered automatically — intentionally left out here to keep the release-branch change minimal. Pull Request resolved: #2098 Reviewed By: cortinico Differential Revision: D110871586 Pulled By: cipolleschi fbshipit-source-id: 383d1db39955d88b56ab84fb709073d2b00f4467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the
260318099.0.0-stablerelease branch for releasing:1. Run CI on the branch (push + PRs)
The build jobs (
build_hermesc_windows,build_hermesc_apple,build_hermesc_linux,build_android, etc.) are reusableon: workflow_callworkflows — they only run when the orchestratorrn-build-hermes.yml("RN Build Static Hermes") invokes them, and itspush/pull_requesttriggers use branch allowlists that were missing this release branch. Added260318099.0.0-stableto both:2. Bump package version
npm/hermes-compiler/package.jsonwas still250829098.0.0(the previous train). Bumped it to260318099.0.0to match this branch's release train.Verification
Confirmed on this PR: the
RN Build Static Hermesworkflow is triggered by thepull_requestevent, andset_release_type+ thebuild_hermesc_*/build_androidjobs run.Note
The allowlists must be updated by hand for every new stable branch. A follow-up could switch them to a glob (e.g.
- '*-stable') so future release branches are covered automatically — intentionally left out here to keep the release-branch change minimal.