Skip to content

chore: switch to @tony.ganchev/eslint-plugin-header#11803

Open
tonyganchev wants to merge 1 commit intofacebook:mainfrom
tonyganchev:main
Open

chore: switch to @tony.ganchev/eslint-plugin-header#11803
tonyganchev wants to merge 1 commit intofacebook:mainfrom
tonyganchev:main

Conversation

@tonyganchev
Copy link

@tonyganchev tonyganchev commented Mar 13, 2026

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.

Motivation

The project is a fork of eslint-plugin-header which has not seen
updates for the last five years.

Benefits of the new plugin:

  • Supports ESLin 9 natively - no schema validation hacks.
  • Supports optional leading comments to support pragma comments such as
    @jest-environment.
  • many bug fixes especially around Windows support.
  • UX improvements.
  • New object-based configuration model in addition to the
    still-supported, eslint-plugin-header array-based configuration
    (but new features only exposed in the new configuration format).
  • Other new features with more coming in the future e.g. separate rule
    to validate years based on git history for use with husky.

Note: because @tony.ganchev/eslint-plugin-header correctly reports the
lines where the lint validation happen, the comment to turn off the
header validation should be the first comment - before the non-standard
header.

Test Plan

yarn lint

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

The project is a fork of _eslint-plugin-header_ which has not seen
updates for the last five years.

Benefits of the new plugin:
- Supports ESLin 9 natively - no schema validation hacks.
- Supports optional leading comments to support pragma comments such as
  `@jest-environment`.
- many bug fixes especially around Windows support.
- UX improvements.
- New object-based configuration model in addition to the
  still-supported, _eslint-plugin-header_ array-based configuration
  (but new features only exposed in the new configuration format).
- Other new features with more coming in the future e.g. separate rule
  to validate years based on git history for use with husky.

Note: because _@tony.ganchev/eslint-plugin-header_ correctly reports the
lines where the lint validation happen, the comment to turn off the
header validation should be the first comment - before the non-standard
header.

Signed-off-by: Tony Ganchev <tony.ganchev@gmail.com>
@meta-cla
Copy link

meta-cla bot commented Mar 13, 2026

Hi @tonyganchev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@socket-security
Copy link

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/@docusaurus/preset-classic@3.9.2npm/@docusaurus/core@3.9.2npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/@docusaurus/preset-classic@3.9.2npm/@docusaurus/core@3.9.2npm/entities@6.0.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@6.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@netlify
Copy link

netlify bot commented Mar 13, 2026

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 6c510d5
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/69b3fa1025f8460008b8c8a9
😎 Deploy Preview https://deploy-preview-11803--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla
Copy link

meta-cla bot commented Mar 13, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed Signed Facebook CLA label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant