chore: switch to @tony.ganchev/eslint-plugin-header#11803
chore: switch to @tony.ganchev/eslint-plugin-header#11803tonyganchev wants to merge 1 commit intofacebook:mainfrom
Conversation
The project is a fork of _eslint-plugin-header_ which has not seen updates for the last five years. Benefits of the new plugin: - Supports ESLin 9 natively - no schema validation hacks. - Supports optional leading comments to support pragma comments such as `@jest-environment`. - many bug fixes especially around Windows support. - UX improvements. - New object-based configuration model in addition to the still-supported, _eslint-plugin-header_ array-based configuration (but new features only exposed in the new configuration format). - Other new features with more coming in the future e.g. separate rule to validate years based on git history for use with husky. Note: because _@tony.ganchev/eslint-plugin-header_ correctly reports the lines where the lint validation happen, the comment to turn off the header validation should be the first comment - before the non-standard header. Signed-off-by: Tony Ganchev <tony.ganchev@gmail.com>
|
Hi @tonyganchev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Pre-flight checklist
Motivation
The project is a fork of eslint-plugin-header which has not seen
updates for the last five years.
Benefits of the new plugin:
@jest-environment.
still-supported, eslint-plugin-header array-based configuration
(but new features only exposed in the new configuration format).
to validate years based on git history for use with husky.
Note: because @tony.ganchev/eslint-plugin-header correctly reports the
lines where the lint validation happen, the comment to turn off the
header validation should be the first comment - before the non-standard
header.
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs