fix(theme): restore copy-text-to-clipboard as lazy fallback for non-secure contexts#11796
Merged
slorber merged 4 commits intofacebook:mainfrom Mar 12, 2026
Merged
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
slorber
reviewed
Mar 12, 2026
Collaborator
slorber
left a comment
There was a problem hiding this comment.
LGTM thanks
I created a simpler abstraction and added the missing lockfile change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
PR #11422 removed
copy-text-to-clipboardand replaced it withnavigator.clipboard, assuming broad HTTPS adoption. However,navigator.clipboardis only available in secure contexts — it isundefinedin non-HTTPS environments (e.g.http://192.168.x.x:3000on a local network), causing:This PR re-introduces
copy-text-to-clipboardas a lazily loaded fallback: it is only imported via dynamicimport()whennavigator.clipboardis unavailable, so HTTPS users pay no bundle cost.Behavior:
navigator.clipboard.writeText()as beforecopy-text-to-clipboardand uses it as fallbackCloses #11791
Test Plan
To reproduce the bug (before fix):
npm run start -- --host 0.0.0.0http://192.168.x.x:3000from another deviceAfter fix: copy button works on both HTTP and HTTPS.
Related issues/PRs