(Temporary step) Give Experiment a property Data
#4686
Closed
+38
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87004539. |
meta-cla
bot
added
the
CLA Signed
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 18, 2025
Summary: **Context**: In D86452716, we remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. This is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. Solely in order to split that diff up, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Differential Revision: D87004539
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4686 +/- ##
==========================================
- Coverage 96.73% 96.72% -0.01%
==========================================
Files 582 582
Lines 60710 60705 -5
==========================================
- Hits 58726 58719 -7
- Misses 1984 1986 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
esantorella
force-pushed
the
export-D87004539
branch
from
fa67a95 to
4c397c9
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 22, 2025
Summary: **Context**: In D86452716, we remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. This is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. Solely in order to split that diff up, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 23, 2025
Summary: Pull Request resolved: facebook#4686 **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Differential Revision: D87004539
esantorella
force-pushed
the
export-D87004539
branch
from
4c397c9 to
48ed359
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: Pull Request resolved: facebook#4686 **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Differential Revision: D87004539
esantorella
force-pushed
the
export-D87004539
branch
from
48ed359 to
9e60db9
Compare
esantorella
force-pushed
the
export-D87004539
branch
from
9e60db9 to
b8b49bd
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 2, 2026
Summary: Pull Request resolved: facebook#4686 **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
force-pushed
the
export-D87004539
branch
from
b8b49bd to
cd74c6d
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 2, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 2, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 2, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 2, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 2, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
force-pushed
the
export-D87004539
branch
from
cd74c6d to
d8edc0c
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 2, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 5, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
force-pushed
the
export-D87004539
branch
from
d8edc0c to
16fd833
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 5, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 5, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
force-pushed
the
export-D87004539
branch
from
16fd833 to
a7b7aa0
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 5, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Jan 5, 2026
Summary: **Context**: This diff exists to split up a more complex change. The next diff, D86452716, will remove `Experiment`'s attribute `_data_by_trial` and give it an attribute `Data`. That is quite a complex change; in addition to the changes on `Experiment`, it requires storage changes and updating many callsites. As a first step, this diff gives `Experiment` a property `data` (which will become an attribute in D86452716) and updates call sites. It should not be landed alone. **Changes**: * Gives `Experiment` a property `Data` that is equivalent to `.lookup_data()` * Updates many call sites to reference `data` rather than `_data_by_trial` Reviewed By: saitcakmak Differential Revision: D87004539
|
This pull request has been merged in 59b3d62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: In D86452716, we remove
Experiment's attribute_data_by_trialand give it an attributeData. This is quite a complex change; in addition to the changes onExperiment, it requires storage changes and updating many callsites. Solely in order to split that diff up, this diff givesExperimenta propertydata(which will become an attribute in D86452716) and updates call sites.Changes:
Experimenta propertyDatathat is equivalent to.lookup_data()datarather than_data_by_trialDifferential Revision: D87004539