Stress-life prediction function based on the ASME implementation #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Issue: #50 |
Vybornak2
requested changes
Nov 1, 2025
tests/stress_life/test_dam_params.py
Outdated
| from numpy.typing import NDArray | ||
| from fatpy.core.stress_life.demage_parameters import s_eqa_asme | ||
|
|
||
| def test_s_eqa_asme() -> None: |
Collaborator
There was a problem hiding this comment.
more cases should be tested, but that can be done later on.
I recommend to check tests for stress functions
fatpy.struct_mech.stress
Collaborator
|
@itomac As the current issue #50 will be likely simplified, there is no need for changes discussed on the meeting. Please focus on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function for stress-life prediction based on AMSE, including test function is implemented. Please review.