Fix version skew, event-driven load detection, deduplicate API docs#118
Open
Tzero-S wants to merge 1 commit into
Open
Fix version skew, event-driven load detection, deduplicate API docs#118Tzero-S wants to merge 1 commit into
Tzero-S wants to merge 1 commit into
Conversation
- Fix plugin.json version 2.5.2 → 2.5.3 (matches SKILL.md breaking change) - Replace polling waitForLoad with CDP Page.loadEventFired event (zero overhead) - Add general-purpose CDP event listener system (eventListeners Map + addEventListener) - Deduplicate Proxy API docs: SKILL.md → compact quick-ref, cdp-api.md remains canonical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three targeted fixes for the web-access skill.
1. Fix plugin.json version (2.5.2 → 2.5.3)
plugin.jsonandSKILL.mddisagreed on version. This matters because v2.5.3 introduced breaking changes (/newand/navigateswitched from GET to POST).2. Event-driven page load detection
Before:
waitForLoad()polleddocument.readyStateviaRuntime.evaluateevery 500ms.After: Subscribes to
Page.loadEventFiredCDP event (zero polling, instant response) with a one-shotRuntime.evaluatefallback for already-loaded cached pages.Also adds a general
eventListenersMap +addEventListener()for routing unsolicited CDP events — reusable by other proxy features.3. Deduplicate API documentation
SKILL.mdhad a full 13-endpoint curl listing duplicatingreferences/cdp-api.md. Replaced with compact quick-reference table and explicit delegation tocdp-api.md.Files changed
.claude-plugin/plugin.jsonSKILL.mdscripts/cdp-proxy.mjs