fixing flipped screen problem

[doccaz]

I noticed that the original spice5-html had this issue as well, and it was fixed in this patch:
https://cgit.freedesktop.org/~pgrunt/spice-html5/commit/?h=topdown

... which if I understood correctly, is just implementing a "topdown" (e.g. invert the coordinates for drawing) on a particular packet type/color depth, SPICE_SURFACE_FMT_32_xRGB.

Looking through the sources for the eyeOS web client, I found this in lib/images/bitmap.js:

                if(!topdown) {
                        ret = wdi.RasterOperation.flip(ret);
                }

Looking further up, we find the part of the code that deals with 32-bit color packets. It's called wdi.SpiceBitmapFmt.SPICE_BITMAP_FMT_32BIT here.
To fix it, I added a " topdown = true" statement. I've tested with a few of my own VMs that were experiencing this bug, especially in text mode. So far none have regressed.

[doccaz]

This seems to fix the following open issues: #22 and #33 .

[pgurenko]

@doccaz, as of now, the fix helps when desktop is showing initially:

but after next mouse over, weird flips still happen:

It looks like guys from flexVDI are trying to address the same issue with flag received from server: flexVDI@6d491df#diff-fbf4b1476b4fa5b149be11ff1ebd0625

But even with their revision, I have pretty much the same problem - flipped redrawing on mouse move.

It could be the spice guest tools qxl driver-related problem though which is installed on the VM.

[pgurenko]

Fixed in FlexVDI fork (flexVDI#1): there, topdown is a flag from server and no need to explicitly setting it anymore.