feat: improve IconList layout with responsive columns#329
Open
ophirbucai wants to merge 7 commits intoexpo:masterfrom
Open
feat: improve IconList layout with responsive columns#329ophirbucai wants to merge 7 commits intoexpo:masterfrom
ophirbucai wants to merge 7 commits intoexpo:masterfrom
Conversation
… the window's width
|
@ophirbucai is attempting to deploy a commit to the Expo Team on Vercel. A member of the Team first needs to authorize it. |
PierreJanineh
approved these changes
Apr 26, 2025
PierreJanineh
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The icon list provides a way for users to navigate through supported icons. It currently supports only one column (implemented with a FlatList). On desktop, we can improve browsing experience by adding support for multiple column layout (grid-like), ensuring ample spacing between the items so they don't feel cramped together.
How
useWindowDimensionshook.329.mp4