Skip to content

chore(deps): update dependency golangci/golangci-lint to v2.11.4 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janishorsts merged 2 commits into from
Apr 13, 2026
Merged

chore(deps): update dependency golangci/golangci-lint to v2.11.4 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a5280
chore(deps): update dependency golangci/golangci-lint to v2.11.4
renovate[bot] Apr 10, 2026
19957f5
fix: lint issues
janishorsts Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ jobs:
- name: Lint
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9
with:
version: v2.9.0
version: v2.11.4
- name: Test
run: go test -v ./...
6 changes: 4 additions & 2 deletions example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package request_test

import (
"context"
"fmt"
"net/http"
"net/http/httptest"
Expand All @@ -10,7 +11,8 @@ import (
)

func ExampleDecode() {
r := httptest.NewRequest(
r := httptest.NewRequestWithContext(
context.Background(),
http.MethodPost,
"/?filterType=pending,approved&clientId=4&filterClientIds=1|2|3",
strings.NewReader(`{"id":1}`),
Expand All @@ -36,7 +38,7 @@ func ExampleDecode() {
}

func ExampleDecoder_Decode() {
r := httptest.NewRequest(http.MethodPost, "/?ids=1,2,3", nil)
r := httptest.NewRequestWithContext(context.Background(), http.MethodPost, "/?ids=1,2,3", nil)

var req struct {
IDs []int
Expand Down
1 change: 1 addition & 0 deletions request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,6 +576,7 @@ func setValue(rv reflect.Value, values []string) error {

const bitsPerByte = 8

//nolint:gosec // A Go type size will never realistically overflow number types.
bitSize := func() int { return int(rv.Type().Size()) * bitsPerByte }

value := values[0]
Expand Down
44 changes: 22 additions & 22 deletions request_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func testQuery[T comparable](t *testing.T) {
queries := make(url.Values)
queries.Set("value", fmt.Sprint(v))

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -41,7 +41,7 @@ func testQuery[T comparable](t *testing.T) {
func TestDecodePointerToStruct(t *testing.T) {
t.Parallel()

r := httptest.NewRequest(http.MethodGet, "/", nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil)

want := "call of Decode passes non-pointer as second argument"

Expand Down Expand Up @@ -92,7 +92,7 @@ func TestDecodeQuerySlice(t *testing.T) {
queries.Add("value", v[i])
}

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -118,7 +118,7 @@ func TestDecodeQueryByteSlice(t *testing.T) {
queries := make(url.Values)
queries.Set("value", v)

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand Down Expand Up @@ -151,7 +151,7 @@ func TestDecodeQueryImploded(t *testing.T) {
queries.Set("value", strings.Join(v, ","))
}

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand Down Expand Up @@ -180,7 +180,7 @@ func TestDecodeQueryExploded(t *testing.T) {
queries.Add("value", v[i])
}

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -202,7 +202,7 @@ func TestDecodeInvalidTag(t *testing.T) {
Value []string `oas:"value,query,expanded"`
}

r := httptest.NewRequest(http.MethodGet, "/", nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil)

err := Decode(r, &req)
if err == nil {
Expand All @@ -228,7 +228,7 @@ func TestDecodeQuerySliceSpace(t *testing.T) {
queries.Set("value", strings.Join(v, " "))
}

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand Down Expand Up @@ -260,7 +260,7 @@ func TestDecodeQuerySlicePipe(t *testing.T) {
queries.Set("value", strings.Join(v, "|"))
}

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -282,7 +282,7 @@ func TestDecodeQuerySliceEmpty(t *testing.T) {
Fields []string
}

r := httptest.NewRequest(http.MethodGet, "/?fields=", nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?fields=", nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -302,7 +302,7 @@ func TestDecodeQueryOptional(t *testing.T) {
Field bool `oas:"field,query"`
}

r := httptest.NewRequest(http.MethodGet, "/", nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -323,7 +323,7 @@ func TestDecodeQueryRequired(t *testing.T) {

queries := make(url.Values)

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

want := "query param 'field' is required"

Expand Down Expand Up @@ -354,7 +354,7 @@ func TestDecodeQueryFieldName(t *testing.T) {
queries.Add("fieldthree", "fuzz")
queries.Add("FIELDTHREE", "bazz")

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

var got req

Expand Down Expand Up @@ -388,7 +388,7 @@ func TestDecodeQueryIgnore(t *testing.T) {
queries := make(url.Values)
queries.Set("field", "foobar")

r := httptest.NewRequest(http.MethodGet, "/?"+queries.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+queries.Encode(), nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -413,7 +413,7 @@ func TestDecodeQueryDeep(t *testing.T) {
query.Set("filter[search]", v.Search)
query.Set("filter[gt]", strconv.Itoa(int(v.Gt)))

r := httptest.NewRequest(http.MethodGet, "/?"+query.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+query.Encode(), nil)

var req struct {
Filter `oas:"filter,query,deepObject"`
Expand Down Expand Up @@ -455,7 +455,7 @@ func TestDecodeUnmarshalText(t *testing.T) {
Sort
}

r := httptest.NewRequest(http.MethodGet, "/?sort=name", nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?sort=name", nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -480,7 +480,7 @@ func TestDecodeJSONBody(t *testing.T) {
} `oas:",body,json"`
}

r := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(`{"id":9}`))
r := httptest.NewRequestWithContext(t.Context(), http.MethodPost, "/", strings.NewReader(`{"id":9}`))

err := Decode(r, &req)
if err != nil {
Expand All @@ -501,7 +501,7 @@ func TestDecodeXMLBody(t *testing.T) {
} `oas:",body,xml"`
}

r := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(`<Body><Id>1</Id></Body>`))
r := httptest.NewRequestWithContext(t.Context(), http.MethodPost, "/", strings.NewReader(`<Body><Id>1</Id></Body>`))

err := Decode(r, &req)
if err != nil {
Expand All @@ -524,7 +524,7 @@ func TestDecoder_DecodePath(t *testing.T) {
}

// Path has no impact on the test. Set path value manually.
r := httptest.NewRequest(http.MethodGet, "/", nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil)
r.SetPathValue("id", strconv.Itoa(id))

err := dec.Decode(r, &req)
Expand Down Expand Up @@ -554,7 +554,7 @@ func TestDecodeEmbeddedStructs(t *testing.T) {
query.Set("rangeEnd", strconv.Itoa(rangeEnd))
query.Set("sort", "name")

r := httptest.NewRequest(http.MethodGet, "/?"+query.Encode(), nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?"+query.Encode(), nil)

var req struct {
Sort
Expand Down Expand Up @@ -586,7 +586,7 @@ func TestDecodeImplodeLastValue(t *testing.T) {
Value string `oas:"value,query,implode"`
}

r := httptest.NewRequest(http.MethodGet, "/?value=first&value=last", nil)
r := httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/?value=first&value=last", nil)

err := Decode(r, &req)
if err != nil {
Expand All @@ -608,7 +608,7 @@ func BenchmarkDecode(b *testing.B) {
} `oas:"deep,deepObject"`
}

r := httptest.NewRequest(http.MethodGet, "/?value=one,two,three&deep[ok]=1", nil)
r := httptest.NewRequestWithContext(b.Context(), http.MethodGet, "/?value=one,two,three&deep[ok]=1", nil)

for b.Loop() {
err = Decode(r, &req)
Expand Down
Loading