Binary document live-reload (auto-update) — rebased onto current master#17
Merged
Conversation
Drives a real reefdoc server in headless Chromium to verify the live-reload pipeline end-to-end (active auto-update, background updated-dot, delete -> missing state). Stubs the CDN PDF viewer so tests run offline. Adds an e2e CI job and an npm run e2e script.
…o integrate/binary-doc-live-reload # Conflicts: # .github/workflows/ci.yml # CHANGELOG.md # README.md # package.json # playwright.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates @yuki-hayashi's binary-document live-reload work (originally #15) onto current master, resolving the conflicts introduced when the document-download feature landed first.
This is a conflict-resolved replacement for #15. All feature commits retain Yuki's original authorship (this branch merges
feat/binary-doc-live-reloadvia a merge commit). #15 can be closed in favor of this once reviewed.Feature (Yuki's work)
Conflicts resolved (document-download had landed first)
Both features independently added a Playwright setup. Reconciled into one:
testMatch: '**/*.{e2e,spec}.js'runs BOTH suites (download.e2e.js+binary-live-reload.spec.js) and excludes the helper files. Union of settings (expect timeout, trace, CI HTML reporter, chromium project).e2ejob running both suites, keeping the failure-artifact upload.1.61.1(Yuki's newer version), exact-pinned per repo convention.[0.10.0]; this feature is a new[0.11.0]section. No content lost.npm run e2e.Verification (all green on the merged tree)
go test -race ./...— passnpm test— 90/90 unit tests (60 download-era + 30 binreload-era)npm run e2e— 8/8 (5 download + 3 binary-live-reload, real binary)go vet/gofmt -lclean; CI YAML validatedCloses #15 (superseded).