Open
Conversation
paolo9921
force-pushed
the
paolo/new_rules
branch
from
fc386c3 to
cac3c1f
Compare
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
paolo9921
commented
Apr 18, 2025
vadorovsky
reviewed
Apr 28, 2025
rules/command_and_control/linux_suspicious_proxychains_activity.yaml
Outdated
Show resolved
Hide resolved
banditopazzo
requested changes
Jun 6, 2025
rules/command_and_control/linux_tunneling_and_port_forwarding.yaml
Outdated
Show resolved
Hide resolved
rules/command_and_control/linux_tunneling_and_port_forwarding.yaml
Outdated
Show resolved
Hide resolved
rules/command_and_control/linux_tunneling_and_port_forwarding.yaml
Outdated
Show resolved
Hide resolved
banditopazzo
requested changes
Jun 13, 2025
added 2 commits
June 13, 2025 16:00
banditopazzo
requested changes
Jun 13, 2025
Comment on lines
+17
to
+19
| "/usr/bin/apt", "/usr/bin/dpkg", "/usr/bin/yum", "/usr/bin/dnf", "/usr/bin/pacman", | ||
| "/usr/bin/rpm", "/usr/bin/zypper", "/usr/bin/emerge", "/usr/bin/nix-env" | ||
| ]) |
Member
There was a problem hiding this comment.
- add
/usr/bin/apt-getor start with - add
/usr/bin/dnf-3,/usr/bin/dnf4,/usr/bin/dnf5or start with
check yocto distribution rpm path
Comment on lines
+16
to
+19
| (payload.filename STARTS_WITH "/usr/bin/systemctl" AND payload.argv CONTAINS "disable" AND (payload.argv CONTAINS "apparmor" OR payload.argv CONTAINS "apparmor.service")) OR | ||
| (payload.filename ENDS_WITH "service" AND payload.argv CONTAINS "apparmor" AND payload.argv CONTAINS "stop") OR | ||
| (payload.filename ENDS_WITH "chkconfig" AND payload.argv CONTAINS "apparmor" AND payload.argv CONTAINS "off") | ||
| ) |
Member
There was a problem hiding this comment.
- typo
attenotin description - it should cover
systemctl stopandsystemctl disable - it should cover
service stopandservice disable(checkservicesyntax)
Comment on lines
+27
to
+28
| condition: (payload.filename STARTS_WITH "/usr/bin/ln" AND payload.argv CONTAINS "/etc/apparmor.d/" AND payload.argv CONTAINS "/etc/apparmor.d/disable/") | ||
| OR (payload.filename STARTS_WITH "/usr/bin/mv" AND payload.argv CONTAINS "/etc/apparmor.d/" AND payload.argv CONTAINS "/etc/apparmor.d/disable/") |
Member
There was a problem hiding this comment.
do not rely on args but switch to FileRename use /usr/bin/ln as image name and put conditions on file path because in file rename events are resolved in absolute form
Comment on lines
+35
to
+40
| condition: ( | ||
| payload.filename STARTS_WITH "/etc/apparmor" OR | ||
| payload.filename STARTS_WITH "/etc/apparmor.d/" OR | ||
| payload.filename STARTS_WITH "/etc/apparmor.conf" | ||
| ) | ||
| AND (payload.flags CONTAINS "O_WRONLY" OR payload.flags CONTAINS "O_RDWR") |
Member
There was a problem hiding this comment.
add exception on eventual apparmor binaries that reads that configurations
Comment on lines
+47
to
+48
| condition: payload.filename STARTS_WITH "/usr/sbin/sysctl" AND | ||
| (payload.argv CONTAINS "apparmor=0" OR payload.argv CONTAINS "kernel.apparmor.enabled=0" OR payload.argv CONTAINS "security=none") |
Member
There was a problem hiding this comment.
- it uses
sysctl, but you should check if it's possible to do the same thing interacting with/sysfilesystem. in that case create a rule below this - check if the new rule on the filesystem is enough
Comment on lines
+56
to
+59
| (payload.filename ENDS_WITH "apparmor_parser" AND (payload.argv CONTAINS "-R" OR payload.argv CONTAINS "--remove")) OR | ||
| (payload.filename ENDS_WITH "aa-teardown") OR | ||
| (payload.filename ENDS_WITH "aa-disable") | ||
| ) |
Member
There was a problem hiding this comment.
check if these utilities utilizes file system under the hood and create a rule on that if it's possible
banditopazzo
requested changes
Jun 30, 2025
| "/usr/bin/apt", "/usr/bin/apt-get","/usr/bin/dpkg", "/usr/bin/yum", | ||
| "/usr/bin/pacman", "/usr/bin/rpm", "/usr/bin/zypper", "/usr/bin/emerge", "/usr/bin/nix-env"] | ||
| OR header.image STARTS_WITH "/usr/bin/dnf" | ||
| ) |
| header.image IN [ | ||
| "/usr/bin/apt", "/usr/bin/apt-get","/usr/bin/dpkg", "/usr/bin/yum", | ||
| "/usr/bin/pacman", "/usr/bin/rpm", "/usr/bin/zypper", "/usr/bin/emerge", "/usr/bin/nix-env"] | ||
| OR header.image STARTS_WITH "/usr/bin/dnf" |
| header.image IN [ | ||
| "/usr/bin/apt", "/usr/bin/apt-get","/usr/bin/dpkg", "/usr/bin/yum", | ||
| "/usr/bin/pacman", "/usr/bin/rpm", "/usr/bin/zypper", "/usr/bin/emerge", "/usr/bin/nix-env"] | ||
| OR header.image STARTS_WITH "/usr/bin/dnf" |
| header.image IN [ | ||
| "/usr/bin/apt", "/usr/bin/apt-get","/usr/bin/dpkg", "/usr/bin/yum", | ||
| "/usr/bin/pacman", "/usr/bin/rpm", "/usr/bin/zypper", "/usr/bin/emerge", "/usr/bin/nix-env"] | ||
| OR header.image STARTS_WITH "/usr/bin/dnf" |
| header.image IN [ | ||
| "/usr/bin/apt", "/usr/bin/apt-get","/usr/bin/dpkg", "/usr/bin/yum", | ||
| "/usr/bin/pacman", "/usr/bin/rpm", "/usr/bin/zypper", "/usr/bin/emerge", "/usr/bin/nix-env"] | ||
| OR header.image STARTS_WITH "/usr/bin/dnf" |
| evade detection after installing a Linux kernel module (LKM). | ||
| condition: header.image == "/usr/bin/dmesg" AND payload.argv CONTAINS "-c" No newline at end of file | ||
| condition: (payload.filename STARTS_WITH "/usr/bin/dmesg" OR payload.filename STARTS_WITH "/bin/dmesg" OR payload.filename STARTS_WITH "/usr/sbin/dmesg") | ||
| AND (payload.argv CONTAINS "-c" OR payload.argv CONTAINS "-C" OR payload.argv CONTAINS "--clear") |
Member
There was a problem hiding this comment.
check if possible to use fileopen event and flags O_TRUNC and/or O_WRITE, O_RDWR
Comment on lines
-16
to
-18
| (payload.filename STARTS_WITH "/usr/bin/systemctl" AND payload.argv CONTAINS "disable" AND (payload.argv CONTAINS "apparmor" OR payload.argv CONTAINS "apparmor.service")) OR | ||
| (payload.filename ENDS_WITH "service" AND payload.argv CONTAINS "apparmor" AND payload.argv CONTAINS "stop") OR | ||
| (payload.filename ENDS_WITH "chkconfig" AND payload.argv CONTAINS "apparmor" AND payload.argv CONTAINS "off") |
Member
There was a problem hiding this comment.
rewrite with file deleted if possible, example symlink to service deleted from /etc/systemd conf dir
| description: Detects modification of AppArmor profiles or configurations. | ||
| condition: ( | ||
| payload.filename STARTS_WITH "/etc/apparmor" OR | ||
| payload.filename STARTS_WITH "/etc/apparmor/" OR |
Member
There was a problem hiding this comment.
you can remove the slash and remove the others already included
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap analysis, partial rule enhancement
Identification of uncovered areas in the ruleset, implementation of new rules
I have
cargo fmt;cargo clippy;cargo testand all tests pass;