accept sound param when creating notification channel#1083
Open
nol13 wants to merge 3 commits intoevollu:masterfrom
Open
accept sound param when creating notification channel#1083nol13 wants to merge 3 commits intoevollu:masterfrom
nol13 wants to merge 3 commits intoevollu:masterfrom
Conversation
phatlaunchdeck
added a commit
to launchdeck/react-native-fcm-updated
that referenced
this pull request
Apr 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept sound param when creating notification channel, fixes #565, at least as it relates to android oreo+, based off the stackoverflow link posted by @illestrater
Also added a check to not crash if priority isn't set since that is supposed to be optional.
First time I've touched Java in a while, but it seems to be working pretty well.