Fix CWE-639 Insecure Direct Object Reference in Session Management#11
Open
kolega-dev-github-app[bot] wants to merge 1 commit into
Open
Fix CWE-639 Insecure Direct Object Reference in Session Management#11kolega-dev-github-app[bot] wants to merge 1 commit into
kolega-dev-github-app[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical CWE-639 Insecure Direct Object Reference (IDOR) vulnerability in session management that allowed authenticated users to access other users' sessions by manipulating the
x-openclaw-session-keyheader.Changes
session-authorization.tsmodule to handle session key parsing, user identity extraction, and strict enforcement of session ownership rulesauthorizeSessionAccess()function that prevents the IDOR attack by validating session ownership before granting accessTesting
The changes can be tested by running the existing test suite and verifying that the IDOR vulnerability has been addressed. Manual testing of session access control can also be performed.