Conversation
|
|
||
| set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake" ${CMAKE_MODULE_PATH}) | ||
|
|
||
| # store CXX compiler id. Used in MKL package. |
There was a problem hiding this comment.
is TM_C_COMPILER_ID really used anywhere?
|
Is it better to have lib_wrapper separated or included ? |
|
It's better to have it included I think. As you can see here: https://github.com/marcuspetschlies/cvc/blob/dev-cpff/Makefile_examples/Makefile.daint.cuda (line 13) because tmLQCD is so poorly engineered one had to link against all of the sub libs anyway. Might as well link against I don't believe that having the functions in lib_wrapper available in tmLQCD itself will harm anyone. |
| # store CXX compiler id. Used in MKL package. | ||
| set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake" ${CMAKE_MODULE_PATH}) | ||
|
|
||
| set(TM_C_COMPILER_ID @CMAKE_C_COMPILER_ID@) |
There was a problem hiding this comment.
@mtaillefumier what I was referring to was that as far as I can tell it's not just the comment which can be removed but all the lines referring to TM_C_COMPILER_ID no? Maybe I'm missing something but I couldn't find this being used elsewhere.
|
Thanks for confirming. The current pr included it in the library so unless something else is missing this pr should be good for merging after review.
Sent from [Proton Mail](https://proton.me/mail/home) for Android.
…-------- Original Message --------
On Friday, 05/29/26 at 11:50 Bartosz Kostrzewa ***@***.***> wrote:
kostrzewa left a comment [(etmc/tmLQCD#694)](#694 (comment))
It's better to have it included I think.
As you can see here:
https://github.com/marcuspetschlies/cvc/blob/dev-cpff/Makefile_examples/Makefile.daint.cuda (line 13)
because tmLQCD is so poorly engineered one had to link against all of the sub libs anyway. Might as well link against -ltmlqcd and be done with it.
I don't believe that having the functions in lib_wrapper available in tmLQCD itself will harm anyone.
—
Reply to this email directly, [view it on GitHub](#694?email_source=notifications&email_token=AHAE5JPXQMHXQKGJM2N4QQT45FMO3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJXGM2DKOJVGY4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4573459568), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHAE5JIQIKMPI6VUF6QC2XT45FMO3AVCNFSM6AAAAACZQRX4DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKNZTGQ2TSNJWHA).
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for [iOS](https://github.com/notifications/mobile/ios/AHAE5JIGTSZHRZFSMFLEEBT45FMO5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJXGM2DKOJVGY4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG) and [Android](https://github.com/notifications/mobile/android/AHAE5JM62M46Q7HEZ5ZTVXL45FMO5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJXGM2DKOJVGY4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA). Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
It would be great if you could take a look at the |
|
I can not find any useful case for it either so I removed it completely. |
|
Thanks @mtaillefumier @jing2li you should now be able to link against tmLQCD again from CVC passing just |
2 participants
The tmLQCD module was not working as intended because of some typo and absence of tmLQCD cmake modules path. This PR solves these issues.