Add method to check component name duplication#76
Open
mmurooka wants to merge 2 commits intoethz-adrl:masterfrom
Open
Add method to check component name duplication#76mmurooka wants to merge 2 commits intoethz-adrl:masterfrom
mmurooka wants to merge 2 commits intoethz-adrl:masterfrom
Conversation
Collaborator
|
@awinkler What do you think about updating the Composite to store a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If composite (e.g., variables, constraints, costs) contain components with the same name, it seems that an unexpected problem will arise (is this understanding correct?)
This Pull Request adds a method to check the name duplication to the
Problemclass. Doing the same thing in user code is difficult becausevariables_is private and there is no access method.(This is a utility that I use locally. It may be worth sharing in the origin repository, so I'll make a pull request.)