Expose spimdisasm pad creation options#540
Open
andresj-sanchez wants to merge 1 commit into
Open
Conversation
Co-authored-by: dreamingmoths <252494949+dreamingmoths@users.noreply.github.com> Co-authored-by: Mc-muffin <8714476+Mc-muffin@users.noreply.github.com>
Author
|
Small correction to the BSS example in the PR description: the intended behavior is not to fold the padding into the previous BSS symbol's Before, with the autogenerated pad label: dlabel "m_tpcSingleton__27clsSingleton<11clsPfSystem>", weak
/* 006E69B8 */ .space 0x04
/* Automatically generated and unreferenced pad */
dlabel D_006E69BC
/* 006E69BC */ .space 0x04Current behavior with dlabel "m_tpcSingleton__27clsSingleton<11clsPfSystem>", weak
/* 006E69B8 */ .space 0x04
enddlabel "m_tpcSingleton__27clsSingleton<11clsPfSystem>"
/* 006E69BC */ .space 0x04So the dummy |
Collaborator
|
Since this uses a feature from a newer spimdisasm version then you need to bump that version in a few places. Would be also nice to mention the new changes in the changelog too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GlobalConfig.Thanks to @dreamingmoths and @Mc-muffin for the help.
Context
Spimdisasm exposes options for controlling autogenerated pad symbols:
This PR exposes those options through splat config as:
This lets projects control whether generated data, rodata, and BSS/SBSS output includes dummy unreferenced pad symbols.
For example, disabling BSS pad creation can fold gaps into the preceding BSS symbol instead of emitting an extra autogenerated pad label:
Instead of:
Notes
create_bss_padsdepends on the companion SpimdisasmCREATE_BSS_PADSoption.Testing
create_data_pads,create_rodata_pads, andcreate_bss_padsmap to the corresponding SpimdisasmGlobalConfigvalues.PYTHONPATH=src python test.py.PYTHONPATH=src python test_n64_entrypoints.py.