feat: migrate to ep_plugin_helpers/toolbar-select

[JohnMcLear]

Summary

Replaces the hand-rolled <select> change handler with the shared toolbarSelect helper from ep_plugin_helpers#17.

- const hs = $('.color-selection, #color-selection');
- hs.on('change', function () {
-   const value = $(this).val();
-   const intValue = parseInt(value, 10);
-   if (!isNaN(intValue)) {
-     context.ace.callWithAce((ace) => {
-       ace.ace_doInsertColors(intValue);
-     }, 'insertColor', true);
-     hs.val('dummy');
-     context.ace.focus();
-   }
- });
+ toolbarSelect({
+   selector: '.color-selection, #color-selection',
+   context,
+   invoke: (ace, value) => ace.ace_doInsertColors(value),
+   op: 'insertColor',
+ });

Behavioral notes

• Same int coercion, same callWithAce op label, same 'dummy' sentinel reset.
• The helper restores focus unconditionally (even on an unusable pick). The previous code only restored focus when the int coerce succeeded; on a no-op pick, focus stayed on the <select>. Restoring focus always is the WCAG-friendly default and matches what ep_headings2 already did.

Status

Draft — depends on:

1. feat(toolbarSelect): DRY up the toolbar <select>-change boilerplate ep_plugin_helpers#17 merging
2. ep_plugin_helpers ≥ 0.6.0 published to npm

Mark ready and update the dep range (already ^0.6.0 in package.json) once both happen.

Refs ether/etherpad#7255

🤖 Generated with Claude Code

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →