ci(risc0): pass GITHUB_TOKEN as secret env to fix rzup rate limits#350
Merged
Conversation
Contributor
Author
|
Hey @han0110 , It looks like the token fix successfully bypassed the rate limit, but it caused ziskup to fetch the latest unpinned version of ZisK (v0.16.1). It looks like v0.16.1 broke the Docker builds for two reasons:
I see you just opened #351 to update ZisK to v0.17.0 (which I assume handles these changes). Once your PR is merged, I can rebase this branch on top of it. Let me know if you'd prefer me to handle this differently in the meantime :) |
han0110
reviewed
May 6, 2026
Collaborator
han0110
left a comment
There was a problem hiding this comment.
Checked the last 3 months workflow github rate limiting failures, all come from rzup installation, which only requires pass GITHUB_TOKEN to risc0's installation script:
RUN --mount=type=secret,id=github_token,env=GITHUB_TOKEN \
/tmp/install_risc0_sdk.sh && rm /tmp/install_risc0_sdk.sh
The rest changes seem not necessary and overkill given the complexity.
4c45906 to
63c20ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Injects GITHUB_TOKEN into the Risc0 Docker build via BuildKit secret mount (env=GITHUB_TOKEN). This prevents the rzup installer from hitting GitHub API rate limits in CI.