[WIP] Playground changes#803
Closed
tibo-pdn wants to merge 38 commits into
Closed
Conversation
# Conflicts: # .env.example
- remove session_secret_key setting from configuration - remove default value for session_secret_key - remove constr() deprecated function to implement new Annotated syntax in configuration.py - add new auth_secret_key setting - deprecated auth_master_key setting (still available to use for a moment) - add default value for auth_secret_key (default = auth_master_key value for retrocompatibility) - add deprecation warning messages - fix EmptyDepencency typo to EmptyDependency - remove usage of auth_master_key in most of the codebase - add typing in IdentityAccessManager property - identify duplicate functions for token encoding (added TODO) - rename get_master_key into get_secret_key - update SessionMiddleware (cookie encoding/decoding) middleware to now use auth_secret_key - update config.yml, config.example.yml and config.test.yml - remove duplicate socket_keepalive in config.test.yml - remove TOKEN_PREFIX from Key(BaseModel) class due to a duplicate from IdentityAccessManager - remove useless comment - remove duplicate content in api.schemas.admin.providers and most of their references - migrate old Provider class calls to the new one (in api.infrastructure.fastapi.schemas.providers) - update some part of the documentation (not complete yet) # Conflicts: # api/schemas/admin/providers.py
- remove MasterNotAllowedException exception - remove hardcoded admin bypass - delete MASTER_USER_ID and MASTER_KEY_ID for MASTER_ID - add auth_master_username setting - add auth_master_password setting - remove use of master key as API key - replace 0 refs to MASTER_ID global variable - add setup_master method in lifespan (WIP: prints still present) - rename master_key to secret_key in IdentityAccessManager
- add master permission in PermissionType (unused for the moment) - update inline documentation - remove useless prints
- restrict the master user permissions to only MASTER instead of the whole list.
- add newline in carbon footprint migration - fix inline doc typo - remove debug prints and add logger prints - check that the master role and user creation runs only at very first run
- update TODO comments to make them clearer
- move MASTER_ID constant into variable.py - rename user into user_id in DELETE /user endpoint
…update, user creation and user update - needs to be tested
- from api.schemas.admin.roles to api.domain.role.entities
- add typing for ecologit class
…aster user anymore
…sto clean architecture - migrate endpoints - add use cases for role, user, and bootstrap - add exceptions
…r user) - remove master role - add security boundaries to prevent deleting last admin user or admin role of OGL - add new bootstrap admin version - add new exceptions, repistories and factories - remove old endpoints - update default admin user and default admin password
…n now delete himself - fix get_postgres_session iterator call - quick fix of Routers class - migrated to clean archi
…MIN) - fix several playground bugs (login page glitch, redis token lock duration, migration issue on local, usage crash, 500 errors) - add shield badge on corresponding admin roles - add background tasks in playground
- still need to test
- fix strategy display when updating a router
- add temporary implementation of update user - add temporary implementation of delete user
… cases - fix typing typo - clean unused bootstrap and hasadmin usecases - add some TODO comments - move use case tests to unit folder instead of integration folder
…ation (load balancing strategy)
- fix some models tests
Contributor
Author
|
The non playground related changes are the body of this PR. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summarized description of what was done in this PR.
Precise the issue that you are resolving.
Overview
This section provides a checklist to help categorize and describe the changes made in this PR.
Area
Please select the area(s) that this PR affects:
If "Other" is selected, please provide more details about the area(s) affected by this PR here, otherwise delete this part.
Type of change
Please select the type of change that this PR introduces:
Definition of Done / Technical changes
Please provide the Definition of Done (DoD) criteria that apply to this PR.
Screenshots / Demo (if applicable)
Please, attach screenshots or a link to a demo / video demonstrating the changes made in this PR.
Breaking changes
Please select one of the following options:
Please describe the breaking change introduced by this PR here, otherwise delete this part.
NB: A breaking change is a modification that is not backwards-compatible and/or changes current functionality.
Quality assurance & Review readiness
Before requesting a review, please take a moment to confirm that the following aspects have been considered and addressed.
This section helps ensure the PR is ready for review, safe to merge, and deployable. If any items are left unchecked, please add a brief explanation for context.
Documentation
Please select one of the following options:
Tests
Please select one or more of the following options:
If no tests were added, please explain why here, otherwise delete this part.
NB: For a concise overview of software testing types, see this Atlassian's guide.
Code Standards
Git & Process Standards
Deployment Notes
If new or updated environment variables are required, please list them here, otherwise delete this part.
If other special deployment steps are required, please describe them here, otherwise delete this part.
Database migration
Please select one of the following options:
Please confirm that the following steps have been completed for the database migration:
api/alembic/versions/folderReviewer Focus
Please provide any specific areas you would like the reviewers to focus on during their review of this PR (complex logic, risky changes, performance-sensitive code, etc.).
Additional Notes
Please provide any additional information or context that may be relevant to this PR, otherwise delete this part.