[Ultra Info Clock] Fix bug with progress bar, use colorpicker module#4222
Open
RKBoss6 wants to merge 7 commits into
Open
[Ultra Info Clock] Fix bug with progress bar, use colorpicker module#4222RKBoss6 wants to merge 7 commits into
RKBoss6 wants to merge 7 commits into
Conversation
Updated version number and added a new dependency.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates Ultra Info’s settings UI to use the shared colorpicker module, and fixes the ClockInfo progress bar calculation to respect info.min and info.v.
Changes:
- Replaced custom color selection menus with
colorpicker-based pickers for Main/Accent colors - Updated progress bar math to use
(v - min) / (max - min)instead of parsinginfo.text - Bumped app version to 0.03 and updated changelog/dependencies
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/ultrainfo/settings.js | Switch settings UI from custom palette menu to colorpicker module |
| apps/ultrainfo/metadata.json | Bump version and add colorpicker dependency |
| apps/ultrainfo/app.js | Fix progress bar computation to use info.v/info.min properly |
| apps/ultrainfo/ChangeLog | Document changes for 0.03 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
This is good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the
colorpickermodule for settings, and uses info.v and info.min rather than trying to parse the text.