[Weather] Add settings for widget customization#4221
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds configurable weather widget options (displayed data, units label, monochrome icon) and adjusts the UI text showing when data was last updated.
Changes:
- Added new widget settings defaults and a settings submenu for widget configuration.
- Refactored widget rendering to support monochrome icon drawing and selectable secondary data text.
- Updated “last updated” formatting in the main app UI and bumped app version/changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/weather/widget.js | Adds widget configuration defaults, data formatting, monochrome icon rendering, and refactors widget draw logic. |
| apps/weather/settings.js | Introduces a “Widget” submenu with options for visibility, monochrome icon, data selection, and unit display. |
| apps/weather/app.js | Changes update-time wording to “Now” / “X … ago” and removes duplicated “ago”. |
| apps/weather/metadata.json | Version bump to 0.32. |
| apps/weather/ChangeLog | Documents new widget configuration menu in 0.32. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
If you drop me an @ when you're done, I'll review |
Contributor
Author
|
Alright, @bobrippling this looks good to go! |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4117, adds settings menu for customizing widgets