Additional API calls#3
Open
stipoy wants to merge 1 commit intoespresso-dev:masterfrom
Open
Conversation
| curl_setopt($ch, CURLOPT_HEADER, true); | ||
|
|
||
| if ($method === 'POST') { | ||
| array_push($headerData, 'Content-Type:application/json'); |
Collaborator
There was a problem hiding this comment.
Please fix the tab spacing here
| throw new ZoomException("Error: getLoginUrl()"); | ||
| } | ||
|
|
||
| public function createUserMeeting($id, $topic = 'New Meeting', $type = '1', $password = 'MTGPASS', $agenda = 'Start Meeting') |
Collaborator
There was a problem hiding this comment.
Not sure if we should be defaulting to these values.
Author
There was a problem hiding this comment.
ok i'll remove default values. think i'll add the other params too.
There was a problem hiding this comment.
Perhaps passing an array of meeting params, or creating a ZoomMeeting class or something like that, may reduce the number of params you need to pass. Also, this would solve the typical order-of-parameters dilemma.
With the array solution, you could then (in the future, if needed) add default parameters with array_merge.
hermanschutte
requested changes
Feb 4, 2021
Collaborator
hermanschutte
left a comment
hermanschutte
left a comment
There was a problem hiding this comment.
Thanks for the PR! Could you please check my comments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added POST support in _makeCall;
Added additional API calls :
Added creareUserMeeting()
Added getUserInfo()