fix: restrict binary signing to espressif org push events only#14
Conversation
Signing was running on all builds including PRs. Since secrets are accessible on internal PRs, unreviewed code could be signed before merge. Now signing only runs on push events in the espressif org, ensuring only merged code gets signed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jakub-kocka
left a comment
There was a problem hiding this comment.
Thank you, @peterdragun, for this security improvement!
👋 Hello peterdragun, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Description
Signing was running on all builds including PRs. Since secrets are accessible on internal PRs, unreviewed code could be signed before merge. Now signing only runs on push events in the espressif org, ensuring only merged code gets signed.
Related
Internal tracker: IDF-15184