Skip to content

fix: restrict binary signing to espressif org push events only#14

Merged
peterdragun merged 1 commit into
masterfrom
sign_master
Apr 21, 2026
Merged

fix: restrict binary signing to espressif org push events only#14
peterdragun merged 1 commit into
masterfrom
sign_master

Conversation

@peterdragun
Copy link
Copy Markdown
Collaborator

Description

Signing was running on all builds including PRs. Since secrets are accessible on internal PRs, unreviewed code could be signed before merge. Now signing only runs on push events in the espressif org, ensuring only merged code gets signed.

Related

Internal tracker: IDF-15184

Signing was running on all builds including PRs. Since secrets are
accessible on internal PRs, unreviewed code could be signed before
merge. Now signing only runs on push events in the espressif org,
ensuring only merged code gets signed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@peterdragun peterdragun requested a review from jakub-kocka April 21, 2026 11:40
Copy link
Copy Markdown

@jakub-kocka jakub-kocka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @peterdragun, for this security improvement!

@github-actions
Copy link
Copy Markdown

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello peterdragun, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0c07c28

@peterdragun peterdragun merged commit 670f601 into master Apr 21, 2026
2 checks passed
@peterdragun peterdragun deleted the sign_master branch April 21, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants