Fix: replace non-standard 'uint' with 'size_t' in to_jpg.cpp#843
Merged
me-no-dev merged 1 commit intoespressif:masterfrom Mar 26, 2026
Merged
Fix: replace non-standard 'uint' with 'size_t' in to_jpg.cpp#843me-no-dev merged 1 commit intoespressif:masterfrom
me-no-dev merged 1 commit intoespressif:masterfrom
Conversation
GCC 15 (shipped with ESP-IDF 6.0) with Picolibc does not provide 'uint' as an implicit typedef. This causes a compilation error on line 191. The rest of the codebase uses a local typedef in jpge.h, but to_jpg.cpp does not include that header. Use size_t to match the type of max_len which buf_size is assigned to.
swoboda1337
force-pushed
the
fix-uint-type
branch
from
f441f25 to
c380175
Compare
swoboda1337
changed the title
Contributor
Author
|
This issue is currently blocking us from using IDF6. Thanks! |
Contributor
Author
|
Thanks! |
Contributor
Author
|
When could we see a new release? IDF 6 support is broken until that happens. Thanks |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP-IDF 6.0 ships GCC 15 and switches the default C library from Newlib to Picolibc. With Picolibc,
uintis not defined as an implicit typedef (it's non-standard and was previously provided by<sys/types.h>on some platforms).This causes a compilation error in
conversions/to_jpg.cppline 191:The file does include
jpge.hwhich definestypedef unsigned int uint;, but that typedef is scoped insidenamespace jpgeand not visible at the point of use (thememory_streamclass on line 191 is in the global namespace).Changed to
size_tto match the type of themax_lenmember thatbuf_sizeis assigned to.