Light RTC_IO refactor#4019
Draft
Dominaezzz wants to merge 6 commits intoesp-rs:mainfrom
Draft
Conversation
Contributor
|
We should probably start by defining the InputSignal/OutputSignal equivalent. On the S3 there is no RTC_IO matrix, just alternate functions, so there are no numbered signals just yet, but on P4 there will be (9.13 LP Peirpheral Signal List). This is mostly just generating two enums from metadata, and the GPIO matrix code could be a good enough template. |
|
New commits in main has made this PR unmergable. Please resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
cc @bugadani, let's design here.
I'm still trying to figure out the macro lol.
Testing
👀