feat: Add WiFi CLI for runtime (re-)configuration#12
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
There was a problem hiding this comment.
Pull Request Overview
Adds a runtime CLI for WiFi and GUI control, refactors server startup/teardown via task on IP event, and updates configurations and docs to support C++ exceptions and new commands.
- Enable C++ exceptions and update dependencies/config
- Refactor
app_mainand move server setup into event-driven task - Expose new CLI commands for GUI actions and extend
GuiAPI
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdkconfig.defaults | Turn on C++ exceptions |
| main/main.cpp | Alias hardware, centralize server logic, add CLI menu and commands |
| main/idf_component.yml | Adjust dependency rules and add espp/cli |
| main/Kconfig.projbuild | Clear default SSID/password values |
| components/gui/src/gui.cpp | Implement new clear_plots and clear_logs with display refresh |
| components/gui/include/gui.hpp | Declare new clear_plots and clear_logs methods |
| README.md | Reorganize and expand usage, development, and CLI instructions |
| .github/workflows/package_main.yml | Update artifact path logic for release packaging |
Comments suppressed due to low confidence (3)
main/main.cpp:235
- The
start_serverfunction signature expects astd::mutex&but you use astd::recursive_mutexforserver_mutex. Either change the parameter tostd::recursive_mutex&or switch to a non-recursivestd::mutexto avoid type mismatch.
bool start_server(std::mutex &m, std::condition_variable &cv, bool &task_notified) {
.github/workflows/package_main.yml:66
- The workflow removed
cd ${{ matrix.build.path }}so this zip command may run in the repo root instead of the build directory. Consider reintroducingcd ${{ matrix.build.path }}or specifying the path in the zip arguments.
zip -r -j $zip_name build/*.bin build/*.elf build/bootloader/bootloader.bin build/partition_table/partition-table.bin build/flasher_args.json build/flash_args
main/idf_component.yml:17
- Unquoted expressions in
rulesmay not be recognized by the IDF parser. It's safer to quote the condition asif: "target in [esp32s3]"to match the component spec.
- if: target in [esp32s3]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Previously, the CI builds which were attached to releases had no valid WiFi information, and there was no way to (re-)configure the WiFi network at runtime. There was also no side channel to configure / command the display, except via WiFi. This PR fixes both those issues by adding a CLI which enables NVS-backed WiFi reconfiguration as well as direct GUI control.
How has this been tested?
Build and run
mainonesp-boxand use the GUI to test the various commandsScreenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.