feat: Re-enable recoloring for text window logs#10
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to re-enable text recoloring in the text window logs and adjust the task stack size for the GUI component.
- Reintroduces the call to enable text recoloring in the text window.
- Increases the task's stack size from 6 KB to 10 KB for the GUI task.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| components/gui/src/text_window.cpp | Re-enables text recoloring by uncommenting the API call. |
| components/gui/include/gui.hpp | Increases the task stack size in the GUI configuration. |
Comments suppressed due to low confidence (2)
components/gui/src/text_window.cpp:5
- The obsolete comment about text recoloring is removed. Consider removing any redundant comments referencing deprecated behavior to avoid confusion in the future.
// lv_label_set_recolor(log_container_, true);
components/gui/include/gui.hpp:44
- The task's stack size has been increased; please ensure that this change is well justified and consider adding a comment explaining the reason for the increased size.
.task_config = {.name = "Gui Task", .stack_size_bytes = 10 * 1024}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.