Conversation
…ime WiFi configuration
|
✅Static analysis result - no issues found! ✅ |
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades to espp v1.0.10, restructures app_main to use a CLI-based WiFi STA menu for runtime configuration, and adjusts defaults to connect to saved WiFi credentials by default.
- Update to esp-cpp/espp v1.0.10 and enable C++ exceptions
- Refactor
main.cppinto helper functions and integrateWifiStaMenu+ CLI - Set default SSID/password to empty and adjust Kconfig to use saved WiFi NVS
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdkconfig.defaults | Enable C++ exceptions (CONFIG_COMPILER_CXX_EXCEPTIONS=y) |
| main/main.cpp | Refactor app_main into initialize_camera, start_rtsp_server, camera_task_fn; add CLI menu for runtime WiFi and camera interaction |
| main/Kconfig.projbuild | Change ESP_WIFI_SSID/ESP_WIFI_PASSWORD defaults to empty |
Comments suppressed due to low confidence (2)
main/main.cpp:105
- [nitpick] The new CLI commands (
memory,battery) are useful but currently untested. Adding unit or integration tests forWifiStaMenuand the CLI handlers would help ensure correct behavior and catch regressions.
espp::WifiStaMenu sta_menu(wifi_sta);
main/main.cpp:31
- [nitpick] Helper functions
initialize_camera,start_rtsp_server, andcamera_task_fnlack doc comments. Adding brief descriptions of their responsibilities and parameters will improve maintainability.
esp_err_t initialize_camera(void);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
maincode to use CLI and move various parts into their own functions for clarity / reuseMotivation and Context
Closes #11
How has this been tested?
Build and run
mainon ESP32-TimerCam hardware, use CLI to configure it.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.