chore: Update dependencies and remove submodules#10
Merged
Conversation
|
✅Static analysis result - no issues found! ✅ |
Merged
6 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency management by removing submodules and switching to the IDF component manager while also refreshing build configurations and workflows. Key changes include:
- Removing submodules and updating associated configuration files.
- Updating CMakeLists.txt to require CMake 3.20 and adjusting component paths.
- Revising GitHub workflows and the main application code for updated dependency versions and lambda parameter types.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdkconfig.defaults | Removed an unused SPIRAM mode config and added camera-specific config. |
| main/main.cpp | Changed lambda parameters to const references for better const safety. |
| main/idf_component.yml | Added an IDF component manifest with updated dependency versions. |
| components/espp | Removed the espp submodule. |
| components/esp32-camera | Updated the submodule commit URL and commit hash. |
| components/esp-protocols | Removed the esp-protocols submodule. |
| CMakeLists.txt | Updated CMake version to 3.20 and removed paths for submodule directories. |
| .gitmodules | Removed entries for several submodules and updated the camera submodule URL. |
| .github/workflows/static_analysis.yml | Updated ESP-IDF version and cppcheck arguments. |
| .github/workflows/package_main.yml | Revised artifact upload configuration and updated action versions. |
| .github/workflows/build.yml | Updated ESP-IDF version for the main build workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Helps keep the repo up to date without requiring as much work. Decreases clone time and file system utilization of repo.
How has this been tested?
Build and run
mainon esp32-timer-cam hardware.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.