MIM-2666 Align mod_caps hashing with XEP-0300 and XEP-0414#4679
MIM-2666 Align mod_caps hashing with XEP-0300 and XEP-0414#4679chrzaszcz merged 4 commits intofeature/capsfrom
Conversation
- Fix the hash namespace, and update its name to make it more obvious it is version 2 - Drop support for shake* algorithms not mentioned in XEP-0414 - Drop support for MD5 algorithm, which is a 'MUST NOT' in XEP-0414 - Advertise hash features as required by XEP-0300 section 5 Ex. 2
|
CircleCI results for 615d08d elasticsearch_and_cassandra_latest / elasticsearch_and_cassandra_mnesia / 7a1478a small_tests_legacy / small_tests / 7a1478a small_tests_latest / small_tests / 7a1478a small_tests_latest_arm64 / small_tests / 7a1478a ldap_mnesia_legacy / ldap_mnesia / 7a1478a ldap_mnesia_latest / ldap_mnesia / 7a1478a dynamic_domains_pgsql_mnesia_legacy / pgsql_mnesia / 7a1478a internal_mnesia_latest / internal_mnesia / 7a1478a dynamic_domains_mysql_redis_latest / mysql_redis / 7a1478a pgsql_cets_latest / pgsql_cets / 7a1478a dynamic_domains_pgsql_mnesia_latest / pgsql_mnesia / 7a1478a pgsql_mnesia_legacy / pgsql_mnesia / 7a1478a cockroachdb_cets_latest / cockroachdb_cets / 7a1478a mysql_redis_latest / mysql_redis / 7a1478a pgsql_mnesia_latest / pgsql_mnesia / 7a1478a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/caps #4679 +/- ##
================================================
- Coverage 85.76% 85.76% -0.01%
================================================
Files 551 551
Lines 33168 33166 -2
================================================
- Hits 28448 28446 -2
Misses 4720 4720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes:
hashesnamespace.MUST NOTin XEP-0414.shake*functions, which are not mentioned in XEP-0300 or XEP-0414 at all, and were just included because they appeared in IANA hash function text names. I don't see a reason why anyone would use them for entity capabilities. They were also XOF functions, and their lengths was chosen a bit arbitrarily.Notes: