Skip to content

chore: cli refactor#30

Open
eschmidt42 wants to merge 26 commits into
mainfrom
chore/cli-refactor
Open

chore: cli refactor#30
eschmidt42 wants to merge 26 commits into
mainfrom
chore/cli-refactor

Conversation

@eschmidt42
Copy link
Copy Markdown
Owner

This pull request makes significant improvements to the CLI structure and code organization for the fintl project, focusing on modularizing CLI commands, updating documentation, and cleaning up import paths. The CLI commands for ETL, plotting, searching, and storing are now organized into their own modules, and the documentation and test configuration have been updated to reflect the new structure. Additionally, imports in notebooks and code have been cleaned up for consistency.

CLI Refactoring and Modularization:

  • Introduced new CLI command modules: etl.py, plot/core.py, search/core.py, and store/core.py, each exposing a run function for their respective commands. The main CLI entrypoint now imports these functions from fintl.cli.commands. [1] [2] [3] [4]
  • Moved plotting logic from cli/plot.py to cli/commands/plot/helper.py, splitting responsibilities into display_plot, draw_plot, and load_data functions for better separation of concerns. [1] [2]
  • Refactored the interactive search tool: moved the TUI code to cli/commands/search/tui.py, constants to search/constants.py, data helpers to search/helper.py, and validators to search/validators.py. [1] [2] [3]

Documentation and Configuration Updates:

  • Updated the CLI README to reflect the new file organization, including new import paths and file locations for providers, services, and parsers. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]
  • Updated test configuration paths in dev-config.toml to match the new directory structure for test data.

Import Path and Notebook Cleanup:

  • Updated imports in notebooks to match the new CLI and common module structure, improving consistency and maintainability. [1] [2] [3] [4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant