chore: cli refactor#30
Open
eschmidt42 wants to merge 26 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the CLI structure and code organization for the
fintlproject, focusing on modularizing CLI commands, updating documentation, and cleaning up import paths. The CLI commands for ETL, plotting, searching, and storing are now organized into their own modules, and the documentation and test configuration have been updated to reflect the new structure. Additionally, imports in notebooks and code have been cleaned up for consistency.CLI Refactoring and Modularization:
etl.py,plot/core.py,search/core.py, andstore/core.py, each exposing arunfunction for their respective commands. The main CLI entrypoint now imports these functions fromfintl.cli.commands. [1] [2] [3] [4]cli/plot.pytocli/commands/plot/helper.py, splitting responsibilities intodisplay_plot,draw_plot, andload_datafunctions for better separation of concerns. [1] [2]cli/commands/search/tui.py, constants tosearch/constants.py, data helpers tosearch/helper.py, and validators tosearch/validators.py. [1] [2] [3]Documentation and Configuration Updates:
dev-config.tomlto match the new directory structure for test data.Import Path and Notebook Cleanup: