test: coverage update#27
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 99.45% 99.48% +0.02%
==========================================
Files 81 83 +2
Lines 6097 6223 +126
Branches 237 238 +1
==========================================
+ Hits 6064 6191 +127
+ Misses 25 24 -1
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the test suite for DKB account ETL providers and related utilities. The main focus is on making test data management more robust and maintainable by introducing pytest fixtures for test file paths, improving parameterization, and standardizing file handling across tests. Additionally, new tests are added for number conversion and transaction utilities.
Test suite refactoring and improvements:
csv_file,csv_fname,files_root_path), making tests more maintainable and flexible. This change affects test setup, file existence checks, and parameter passing throughout the test files. [1] [2] [3] [4] [5]New and improved test coverage:
test_number_conversion.pyfor German number parsing and conversion utilities, including error handling and currency stripping.test_transactions.pyfor transaction hashing and verification utilities, including error scenarios.Utility function integration:
balance_csv_name_to_json,balance_csv_name_to_parquet,transaction_csv_name_to_parquet,transaction_csv_name_to_xlsx), ensuring consistency with production code. [1] [2] [3]These changes collectively improve the maintainability, reliability, and readability of the test codebase, and make it easier to add new test cases or modify existing ones as the ETL logic evolves.