Skip to content

test: coverage update#27

Merged
eschmidt42 merged 4 commits into
mainfrom
test/coverage-update
May 10, 2026
Merged

test: coverage update#27
eschmidt42 merged 4 commits into
mainfrom
test/coverage-update

Conversation

@eschmidt42
Copy link
Copy Markdown
Owner

@eschmidt42 eschmidt42 commented May 10, 2026

This pull request refactors and improves the test suite for DKB account ETL providers and related utilities. The main focus is on making test data management more robust and maintainable by introducing pytest fixtures for test file paths, improving parameterization, and standardizing file handling across tests. Additionally, new tests are added for number conversion and transaction utilities.

Test suite refactoring and improvements:

  • Replaced hardcoded file paths in tests for DKB credit, festgeld, giro, and related providers with pytest fixtures (csv_file, csv_fname, files_root_path), making tests more maintainable and flexible. This change affects test setup, file existence checks, and parameter passing throughout the test files. [1] [2] [3] [4] [5]
  • Updated configuration and utility function usage in tests to use the new fixtures and to reference file names dynamically, rather than relying on hardcoded values. This includes changes to how config objects are created in tests and how file paths are constructed. [1] [2] [3] [4] [5] [6]
  • Refactored exception handling tests to use the new file fixtures, ensuring that error scenarios are tested with dynamically provided file paths. [1] [2] [3] [4]

New and improved test coverage:

  • Added new tests in test_number_conversion.py for German number parsing and conversion utilities, including error handling and currency stripping.
  • Added new tests in test_transactions.py for transaction hashing and verification utilities, including error scenarios.

Utility function integration:

  • Updated tests to use utility functions for generating output file names (balance_csv_name_to_json, balance_csv_name_to_parquet, transaction_csv_name_to_parquet, transaction_csv_name_to_xlsx), ensuring consistency with production code. [1] [2] [3]

These changes collectively improve the maintainability, reliability, and readability of the test codebase, and make it easier to add new test cases or modify existing ones as the ETL logic evolves.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.48%. Comparing base (3ca9ce0) to head (f5c8219).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   99.45%   99.48%   +0.02%     
==========================================
  Files          81       83       +2     
  Lines        6097     6223     +126     
  Branches      237      238       +1     
==========================================
+ Hits         6064     6191     +127     
+ Misses         25       24       -1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eschmidt42 eschmidt42 merged commit 29f8a8b into main May 10, 2026
3 checks passed
@eschmidt42 eschmidt42 deleted the test/coverage-update branch May 10, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant