ASCOM camera driver support#9
Conversation
This reverts commit cb23ccf.
gustavmpettersson
left a comment
gustavmpettersson
left a comment
There was a problem hiding this comment.
See some specific code comments.
Remove all use of hasattr, instead set all self._ascom variables necessary to None in the constructor.
Several try-except blocks are catch-all, must be fixed.
For properties that can not be set, raise AttributeError instead of returning False.
Finally the big-ticket item, there is here a thread constantly triggering and reading out the ascom camera. Is there no image event support in ascom? The present implementation is going to be very slow.
Please work on these and make a new pull request onto hw_ascom branch.
| if name is not None: | ||
| self.name = name | ||
| if auto_init and not None in (model, identity): | ||
| if auto_init and model is not None: |
There was a problem hiding this comment.
Check if model is ptgrey, if true must check identity is not None before auto init.
| - For model *ascom*, a driver name may be specified if known, (i.e. DSLR, ASICamera1, ASICamera2, | ||
| QHYCCD, QHYCCD_GUIDER, QHYCCD_CAM2, AtikCameras, AtikCameras2, etc), otherwise the ASCOM driver | ||
| selector will open. |
There was a problem hiding this comment.
Does ascom have any way of identifying individual hardware resources? E.g. what happens if I have two cameras connected?
Changed device model selectin to ComboBox pull-down; fixed ascom camera gain/exposure setting methods; various fixed tested with iOptron AZMP and asi174 cameras
enables TCP link from SkyTrack
2 participants
Main changes:
The ASCOM implementation is still pretty rough, but it works with several ASCOM-enabled astronomy cameras. Tested with asi120mc, asi174mm, qhy5Lii-m, and ASCOM camera simulator. Needs review for style consistency and error handling.