Fix Dialyzer warnings and logic errors in option validation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function could report present options as missing: it stopped at the first missing option and returned it with the rest of the list which could contain options that are actually present.
Previously, validators would crash on {no_validator, _} or {invalid_options, _}
tuples because the case clause only expected {invalid, _} or valid.
- Add `is_list(Fields)` guard to `map_validator:validate/3`.
- Add a catch-all clause to return `{invalid_option_value, not_list}`
if the `fields` option is not a list, preventing a crash.
- Add tests for map_validator:
- missing mandatory options
- invalid/Unknown options
- invalid option values (non-list fields)
- handling of unknown validators in fields
zephyrean
force-pushed
the
fix/validation-logic-and-dialyzer
branch
from
0e7e320 to
7d06a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several Dialyzer warnings and logical issues.
Changes:
Fix
has_missing_options/2logiclists:dropwhile/2tolists:filter/2.dropwhilewould stop at the first present option, potentially ignoring missing options later in the list and returning options that are actually presentImprove error propagation in validators
map_validator,map_dynamic_validator,list_validator,tuple_validator, andtuple_dynamic_validator{no_validator, ...}and other possible return valuescase_clausecrash when a nested validator returns errors other than simple invalidation (e.g.,{no_validator, ...},{missing_options, ...}).map_validator: validate
fieldsoption type and add more testsfieldsoption is a list and add a catch-all clauseto return
{invalid_option_value, not_list}preventing a crashmap_validator