Fix SIGQUIT (Ctrl+\) producing a core dump in rebar3 shell#3029
Open
saleyn wants to merge 1 commit into
Open
Conversation
As an escript, rebar3 never initializes the break handler that erl sets up, leaving SIGQUIT at the OS default action of dumping core. Calling os:set_signal(sigquit, handle) aligns rebar3 shell's behavior with a regular erl shell. Fixes erlang#3012 Fix failing test suite compilation on Windows ``` ┌─ apps/rebar/test/rebar_ct_SUITE.erl: │ 1312 │ false = lists:member(Opt, TestOpts). │ ╰── variable 'Opt' exported from list (line 1306, column 19). ``` Fix rebar_xref_SUITE:xref_ignore_test on OTP 29 Since OTP 29, xref natively filters -ignore_xref attributes during xref:analyze, instead of leaving that entirely to rebar3's filter_xref_results/3. As a result, othermod's -ignore_xref([{SomeMod,notavailable,1}, ...]) now also removes {SomeMod,notavailable,1} from undefined_functions (previously only the call-site was filtered, leaving the bare undefined function in the results). Make the assertion OTP-version-conditional. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an escript, rebar3 never initializes the break handler that erl sets up, leaving SIGQUIT at the OS default action of dumping core. Calling os:set_signal(sigquit, handle) aligns rebar3 shell's behavior with a regular erl shell.
Fixes #3012
Fix failing test suite compilation on Windows
Fix rebar_xref_SUITE:xref_ignore_test on OTP 29
Since OTP 29, xref natively filters -ignore_xref attributes during xref:analyze, instead of leaving that entirely to rebar3's filter_xref_results/3. As a result, othermod's
-ignore_xref([{SomeMod,notavailable,1}, ...]) now also removes {SomeMod,notavailable,1} from undefined_functions (previously only the call-site was filtered, leaving the bare undefined function in the results). Make the assertion OTP-version-conditional.