Remove erlware_commons from the rebar3 codebase#3022
Open
GwendalLaurent wants to merge 6 commits into
Open
Conversation
* internalize functions of ec_sermver.erl * move ec_semver_parser inside rebar * remove leftover call to erlware_commons * add SPDX tags in erlware files
* remove ec_file:{is_file, is_dir}/1
* remove ec_file:{mkdir_path,mkdir_p}
* remove ec_file:remove/{2,3}
* add missing files for is_dir refactor
* remove ec_file:{write, write_term}/2
* move ec_file:real_dir_path to rebar_file_utils
* move ec_file:insecure_mkdtemp/0 to rebar_file_utils
* remove ec_file:copy/{2,3}
* remove ec_file:is_symlink/1
* add SPDX headers
* remove ec_lists:search/2 from rebar_packages * add test case for check_all_repo correctness * handle_missing_no_exception refactor * remove ec_lists:search/2 * replace ec_lists:find/2 by lists:search/2 + refactoring of callers * add SPDX headers
* refactoring the logs to remove ec_cmd_logs
* remove ec_cnv * restore r3_safe_erl_term * add SPDX headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our work on the rebar4 kickstarter at Peer Stritzinger GmbH, we are removing externally vendored code from the rebar3 codebase.
erlware_commonsis currently causing compatibility and CI issues with OTP 29. This PR removeserlware_commonsfrom the rebar3 codebase entirely.The work is split into two phases:
erlware_commonsmodules.erlware_commonscode itself.The refactoring was originally developed in smaller steps in our fork, then consolidated here into an upstream-ready branch.