feat(mcp): Phase 3 — tools/call dispatch boundary#359
Merged
Conversation
Refs #293 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
무엇
Wire MCP
tools/callthrough a src/mcp handler dispatch boundary and convert placeholdertodo!()stubs into structured MCP error envelopes.왜
Refs #293. The stdio server already accepts
tools/call; this phase makes the call path exercise real module handlers without panicking, preparing later PRs to replace stubs one tool at a time.변경
src/mcp/tools::dispatchand per-tool handler lookup.McpContextfrom the stdio serve loop into JSON-RPC dispatch.todo!()handler stubs with explicit not-implemented errors.다음 Phase 힌트
Implement the first read-only handler, likely
worktree_statusorhealth_check, behind the new dispatch boundary.리스크
Low. Scoped to
src/mcp/; existing CLI command signatures and core git/worktree logic are unchanged.롤백
Revert this PR to return
tools/callto its previous always-not-implemented response.Test plan
cargo build --quietcargo fmt --checkcargo clippy --all-targets -- -D warningscargo test --quiet@erishforG