Fix GUI installer encryption mapping and history logging#612
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 17, 2026
Merged
Fix GUI installer encryption mapping and history logging#612erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
- Add missing "Optional" case to encryption switch — previously fell through to default (Mandatory), making the dropdown option non-functional - Remove bare catch in LogInstallationHistoryAsync — exceptions now propagate to the caller which already logs them as warnings. Prevents silent history write failures that cause version detection fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughModified the installation service to support optional SQL encryption and refactored installation history logging to detect upgrade/reinstall scenarios by querying prior installation records and tracking additional diagnostic metadata including installer version, SQL Server details, installation type, and execution statistics. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Optional"case — it fell through to the default which mapped toMandatory. Every install using "Optional" encryption was silently using Mandatory.catchinsideLogInstallationHistoryAsync. Exceptions now propagate to the caller atMainWindow.xaml.cs:472which already has proper error handling (LogMessage(..., "Warning")). Previously, a failed history write was invisible, causing the next installer run to fall back to version"1.0.0"and re-run all upgrade scripts.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes